Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix apply config in STORAGE_CLASS_SHARE_MOUNT mode #1122

Merged
merged 3 commits into from
Sep 25, 2024

Conversation

zxh326
Copy link
Member

@zxh326 zxh326 commented Sep 23, 2024

fix: #1065

@zxh326 zxh326 force-pushed the fix-share-storage-class-mode-apply-config branch from d9bbd7b to 83b744e Compare September 24, 2024 03:22
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 27.87%. Comparing base (ad57e95) to head (83b744e).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
pkg/config/setting.go 66.66% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1122      +/-   ##
==========================================
- Coverage   27.96%   27.87%   -0.10%     
==========================================
  Files          51       51              
  Lines        6969     7021      +52     
==========================================
+ Hits         1949     1957       +8     
- Misses       4814     4858      +44     
  Partials      206      206              
Flag Coverage Δ
27.87% <66.66%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zwwhdls zwwhdls merged commit ae32d1c into master Sep 25, 2024
23 checks passed
@zwwhdls zwwhdls deleted the fix-share-storage-class-mode-apply-config branch September 25, 2024 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] restart mountpod cannot apply config in STORAGE_CLASS_SHARE_MOUNT mode
3 participants