Add immutable fluent interface to PropertiesFile::Options#1589
Open
daleonov wants to merge 1 commit intojuce-framework:developfrom
Open
Add immutable fluent interface to PropertiesFile::Options#1589daleonov wants to merge 1 commit intojuce-framework:developfrom
daleonov wants to merge 1 commit intojuce-framework:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now you can do this:
For projects written in C++17, other ways of instantiating this object and modifying just a few selected members is too awkward in my opinion. I had to make a separate builder class with a similar interface, but I believe this
Optionsclass should just have a built-in interface like this. Many other JUCE classes already do, like a similarOptionsclass forFont, alsoFile,String,Rectangle,Colourto name a few off the top of my head, so I was quite surprised to discover that this struct wasn't capable of that.It may also be appropriate to add a few
jasserts and fallbacks in those methods, but since this logic is mostly implemented inPropertiesFileclass, I decided not to do it.