Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I discovered cwe-416 vulnerability in my project. (Sorry for the frequent pull-requests) #1327

Closed
wants to merge 3 commits into from
Closed

I discovered cwe-416 vulnerability in my project. (Sorry for the frequent pull-requests) #1327

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1d20240
found-cwe-416
Jellybin06 Jan 2, 2024
c75d7ef
cwe-416
Jellybin06 Jan 2, 2024
0c49699
cwe-416
Jellybin06 Jan 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions ...uce_audio_processors/format_types/VST3_SDK/public.sdk/source/vst/hosting/module_linux.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,8 +164,10 @@ class LinuxModule : public Module
if (!filesystem::is_directory (modulePath))
return {};

stem.replace_extension (".so");
modulePath /= stem;
auto newStem = stem;
newStem.replace_extension(".so");
modulePath /= newStem;

return Optional<Path> (std::move (modulePath));
}

Expand Down Expand Up @@ -322,12 +324,14 @@ Module::SnapshotList Module::getSnapshots (const std::string& modulePath)
for (auto& png : pngList)
{
filesystem::path p (png);
auto filename = p.filename ().generic_string ();
auto uid = Snapshot::decodeUID (filename);
auto filename = p.filename ().string ();
auto uid = Snapshot::decodeUID(filename.string());

if (!uid)
continue;
auto scaleFactor = 1.;
if (auto decodedScaleFactor = Snapshot::decodeScaleFactor (filename))
auto decodedFilename = filename.string();
if (auto decodedScaleFactor = Snapshot::decodeScaleFactor(decodedFilename))
scaleFactor = *decodedScaleFactor;

Module::Snapshot::ImageDesc desc;
Expand Down Expand Up @@ -366,4 +370,4 @@ Optional<std::string> Module::getModuleInfoPath (const std::string& modulePath)

//------------------------------------------------------------------------
} // Hosting
} // VST3
} // VST3
Loading