Bind before getting groups of user #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases, we will not want to authenticate a user, only get their groups, such as when performing access control for a user authenticated elsewhere. In such a case, we will not have bound the connection to the LDAP server using the read-only user, so if the LDAP server does not allow unauthenticated access, our GetGroupsOfUser call will fail. Ensure we bind using the read-only user, if one is provided, before trying to fetch the user's groups.
Joffcom
added a commit
to Joffcom/go-ldap-client
that referenced
this pull request
Jan 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, we will not want to authenticate a user, only get their groups, such as when performing access control for a user authenticated elsewhere. In such a case, we will not have bound the connection to the LDAP server using the read-only user, so if the LDAP server does not allow unauthenticated access, our GetGroupsOfUser call will fail.
Ensure we bind using the read-only user, if one is provided, before trying to fetch the user's groups.