Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change character constants to enums #12

Merged
merged 1 commit into from
Dec 4, 2019
Merged

Conversation

bryanforbes
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Dec 3, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling b0e87c5 on bryanforbes:use-enum into 568bada on jtauber:master.

@jtauber
Copy link
Owner

jtauber commented Dec 4, 2019

sorry, I merged the other PR first. Can you update this to resolve the conflict? Also can you add yourself to the AUTHORS file?

@jtauber
Copy link
Owner

jtauber commented Dec 4, 2019

would also be good to add some comparison tests which, beside getting coverage % back up, would make sure the comparison you're doing is correct.

I presume the idea is that the Accentuation order based on mora location. That's worth documenting and testing.

@bryanforbes bryanforbes force-pushed the use-enum branch 3 times, most recently from cf7940e to 1f66696 Compare December 4, 2019 01:53
@bryanforbes
Copy link
Contributor Author

I added the comparison methods because sorted() requires __lt__ and adding only that method seemed incomplete. I'll add some tests in extra.rst to exercise them.

@jtauber jtauber merged commit 1f3144d into jtauber:master Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants