Test on Travis CI #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Force-pushed branch adding Travis status in ready file. |
|
I now see that in your other project you install flake8 explicitly in the travis file hence avoid polluting setup.py for this. Please let me know if this is preferred practice and I will update PR (I am not sure about Python best practice). |
|
@lucafavatella thanks for this! Yeah, I don't think the average user of Thanks so much for your contribution and I'm hoping it's the start of lots of collaboration! |
Running flake8 currently reports some errors: ``` accentuation.py:79:80: E501 line too long (81 > 79 characters) accentuation.py:133:80: E501 line too long (122 > 79 characters) accentuation.py:143:80: E501 line too long (80 > 79 characters) ```
|
@jtauber Force-pushed with installation of flake8 in Travis file. Thanks for your feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to enable Travis CI builds on your repository, merging this PR is not enough. Please refer to http://docs.travis-ci.com/user/getting-started/
As described in the commit message, flake8 currently fails. I am not proposing a fix for the reported errors as I am not confident with the coding conventions.