Fix ESLint v10 RuleContext API removal (follow-up to #3972) #3979

ledsun · 2026-02-09T02:35:00Z

This PR follows up on the feedback in the comments of #3972 and incorporates the requested changes.

I think this PR will fix #3977.

ljharb

we'll need regression tests - it might be as simple as adding eslint 10 to the GHA matrix.

@ledsun

Use @ledsun fork. For more see: - jsx-eslint/eslint-plugin-react#3977 - jsx-eslint/eslint-plugin-react#3979

@ledsun

Use @ledsun fork. For more see: - jsx-eslint/eslint-plugin-react#3977 - jsx-eslint/eslint-plugin-react#3979

jsx-eslint#3972

codecov · 2026-02-11T08:15:43Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.69%. Comparing base (25249f3) to head (d143827).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3979      +/-   ##
==========================================
- Coverage   97.85%   97.69%   -0.17%     
==========================================
  Files         136      133       -3     
  Lines       10008    10000       -8     
  Branches     3717     3718       +1     
==========================================
- Hits         9793     9769      -24     
- Misses        215      231      +16

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Run published type checks against both ESLint 7 and 10. Use per-matrix dependency setup and exclude unsupported TS combinations for ESLint 10.

- route filename/sourceCode access through util helpers for ESLint 7/10 compatibility - remove deprecated meta.docs.category to satisfy current RuleModule typings - augment @eslint/core SettingsConfig with react settings shape

socket-security · 2026-02-11T11:06:38Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	eslint@10.0.0

View full report

domarmstrong · 2026-02-12T09:20:36Z

lib/util/eslint.js

 }

+function getFilename(context) {
+  return context.filename || context.getFilename();


It may be better to follow the pattern above, to only call the method if it exists

Suggested change

return context.filename || context.getFilename();

return context.getFilename ? context.getFilename : filename;

domarmstrong · 2026-02-12T09:20:52Z

lib/util/version.js

 function resolveBasedir(contextOrFilename) {
  if (contextOrFilename) {
-    const filename = typeof contextOrFilename === 'string' ? contextOrFilename : contextOrFilename.getFilename();
+    const filename = typeof contextOrFilename === 'string' ? contextOrFilename : contextOrFilename.filename || contextOrFilename.getFilename();


Suggested change

const filename = typeof contextOrFilename === 'string' ? contextOrFilename : contextOrFilename.filename || contextOrFilename.getFilename();

const filename = typeof contextOrFilename === 'string' ? contextOrFilename : getFilename(contextOrFilename);

ljharb reviewed Feb 10, 2026

View reviewed changes

ljharb marked this pull request as draft February 10, 2026 02:09

sergeyklay added a commit to sergeyklay/oar that referenced this pull request Feb 10, 2026

chore(deps-dev): bump eslint from 9.39.2 to 10.0.0

72b1aaf

Use @ledsun fork. For more see: - jsx-eslint/eslint-plugin-react#3977 - jsx-eslint/eslint-plugin-react#3979

sergeyklay mentioned this pull request Feb 10, 2026

chore(deps-dev): bump eslint from 9.39.2 to 10.0.0 sergeyklay/oar#269

Merged

sergeyklay added a commit to sergeyklay/oar that referenced this pull request Feb 10, 2026

chore(deps-dev): bump eslint from 9.39.2 to 10.0.0

30bc6ee

Use @ledsun fork. For more see: - jsx-eslint/eslint-plugin-react#3977 - jsx-eslint/eslint-plugin-react#3979

sergeyklay mentioned this pull request Feb 10, 2026

Track reverting to upstream eslint after temporary fork sergeyklay/oar#270

Open

Copilot AI mentioned this pull request Feb 10, 2026

docs: create ESLint 10 compatibility tracking document sergeyklay/oar#271

Closed

sergeyklay mentioned this pull request Feb 10, 2026

Tracking: ESLint 10 Support sergeyklay/oar#272

Open

6 tasks

tylermumford and others added 3 commits February 11, 2026 17:03

Update types and RuleContext deprecations

69b7fc4

Addresses the feedback provided in the comments on

9c686b5

jsx-eslint#3972

Add ESLint 10 to the Node 18+ CI matrix

a7b967b

ledsun force-pushed the update-deprecated-calls-v8 branch from f987ffa to a7b967b Compare February 11, 2026 08:06

ledsun added 4 commits February 11, 2026 18:59

ci(types): split type-check matrix by ESLint major (7/10)

9932114

Run published type checks against both ESLint 7 and 10. Use per-matrix dependency setup and exclude unsupported TS combinations for ESLint 10.

fix(types): align rule context usage with ESLint 10 typings

54908ab

- route filename/sourceCode access through util helpers for ESLint 7/10 compatibility - remove deprecated meta.docs.category to satisfy current RuleModule typings - augment @eslint/core SettingsConfig with react settings shape

chore: add ESLint v10 support to package.json

56cd100

chore: Add ESLint v10 support to peer dependency

d143827

ledsun added 2 commits February 11, 2026 20:16

ci(type-check): install eslint before typescript in test-published-types

4b2162e

ci(type-check): limit ESLint 10 matrix to TypeScript 5+

1cbaa2f

ledsun marked this pull request as ready for review February 11, 2026 12:08

domarmstrong reviewed Feb 12, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix ESLint v10 RuleContext API removal (follow-up to #3972) #3979

Fix ESLint v10 RuleContext API removal (follow-up to #3972) #3979

Uh oh!

ledsun commented Feb 9, 2026 •

edited

Loading

Uh oh!

ljharb left a comment

Uh oh!

codecov bot commented Feb 11, 2026 •

edited

Loading

Uh oh!

socket-security bot commented Feb 11, 2026 •

edited

Loading

Uh oh!

domarmstrong Feb 12, 2026

Uh oh!

domarmstrong Feb 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

	return context.filename \|\| context.getFilename();
	return context.getFilename ? context.getFilename : filename;

	const filename = typeof contextOrFilename === 'string' ? contextOrFilename : contextOrFilename.filename \|\| contextOrFilename.getFilename();
	const filename = typeof contextOrFilename === 'string' ? contextOrFilename : getFilename(contextOrFilename);

Uh oh!

Fix ESLint v10 RuleContext API removal (follow-up to #3972) #3979

Are you sure you want to change the base?

Fix ESLint v10 RuleContext API removal (follow-up to #3972) #3979

Uh oh!

Conversation

ledsun commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ljharb left a comment

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

socket-security bot commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

domarmstrong Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

domarmstrong Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

ledsun commented Feb 9, 2026 •

edited

Loading

codecov bot commented Feb 11, 2026 •

edited

Loading

socket-security bot commented Feb 11, 2026 •

edited

Loading