-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: async test case switch #50
Open
gijswijs
wants to merge
2
commits into
jstransformers:master
Choose a base branch
from
gijswijs:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tets-jstransformer applies all tests to each method it can find, regardless of the method being asynchronous or not. This is a problem for tests that require a method to be asynchronous. These test cases should only be applied to the asynchronous methods. This commit checks for the text '_async' in the folder name. If it can find it, only the asynchronous test cases are performed. Asynchronous methods are tested on synchronous test cases, because that way around it should work, regardless of a method being asynchronous. `checkFunctionOutput` is now asynchronous. This is done, because it is not a given that `template.fn(locals)` returns a string. Hence this test case can fail because `template.fn(locals).trim()` returns an error. By wrapping it in a `Promise.resolve()` both the situations where `template.fn(locals)` returns a string or a Promise are covered. This is also how the jstranformer library works, so the tests now better mimmick the behavior of the actual library.
The build is failing✨ Good work on this PR so far! ✨ Unfortunately, the Travis CI build is failing as of 79ada17. Here's the output:
|
This was referenced May 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38
Test-jstransformer applies all tests to each method it can find,
regardless of the method being asynchronous or not. This is a problem
for tests that require a method to be asynchronous as mentioned in issue #38 .
These test cases should only be applied to the asynchronous methods. This
commit checks for the text '_async' in the folder name. If it can find it, only the
asynchronous test cases are performed. Asynchronous methods are tested
on synchronous test cases, because that way around it should work,
regardless of a method being asynchronous.
checkFunctionOutput
is now asynchronous. This is done, because it isnot a given that
template.fn(locals)
returns a string. Hence this testcase can fail because
template.fn(locals).trim()
returns an error. Bywrapping it in a
Promise.resolve()
both the situations wheretemplate.fn(locals)
returns a string or a Promise are covered. Thisis also how the jstranformer library works, so the tests now better
mimmick the behavior of the actual library.