[WIP] Refactored MimeReader to use ReadOnlySpan<byte> instead of unsafe byte* #1162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main advantage of this change is to make the code a bit nicer. The AsyncMimeReader code, especially, becomes a lot nicer with this change. The other advantage is that Spans don't interfere with the GC like pinned memory buffers do, which could theoretically mean that using MimeReader is less likely to result in memory fragmentation (although not sure on the real-world consequences of the previous code in practice). The downside is that ReadOnlySpan<byte>.IndexOf() is *slower* than the current implementation on .NET Framework and possibly also even .NET Core where the platform architecture does not have support for SIMD. That's why this PR is a Work-In-Progress and not yet merged to master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main advantage of this change is to make the code a bit nicer. The AsyncMimeReader code, especially, becomes a lot nicer with this change.
The other advantage is that Spans don't interfere with the GC like pinned memory buffers do, which could theoretically mean that using MimeReader is less likely to result in memory fragmentation (although not sure on the real-world consequences of the previous code in practice).
The downside is that ReadOnlySpan.IndexOf() is slower than the current implementation on .NET Framework and possibly also even .NET Core where the platform architecture does not have support for SIMD.
That's why this PR is a Work-In-Progress and not yet merged to master.