Delete [email protected] #784
Conversation
This is causing an old and broken version of has-cors to get installed when you try and install socket.io.
| "parseqs": "0.0.2", | ||
| "component-inherit": "0.0.3" | ||
| } | ||
| } |
There was a problem hiding this comment.
Rather than deleting, we should create a new override for the later version that this isn't needed on.
|
Sure, that makes sense. However, the has-cors dependency can't actually be installed at 1.0.3 due to the use of a git archive as a dependency - so I can't see how this override will work in any case: |
Don't use the old version of "accepts", which requires a version of "negotiator" using dynamic requires.
Allow socket.io to import the socket.io-client package.json.
This doesn't need the json loader - it can just be loaded as javascript.
It seems that I must override all dependencies if I override 1. Which is a shame because I only want to override "accepts".
utf-8-validate and bufferutil are conditionally required causing this module to fail.
|
This now contains everything needed to get socket.io installed and running. I've re-added the (imo broken) version of engine.io-client and added an empty one which allows the latest version to install. I'm not clear why a requirement for [email protected] would be affected by an override for 1.4.5 in any case? Socket.io still cannot run using the npm version due to three issues:
Issues 2&3 are fixed in: salfield/socket.io |
|
Can you remind me if you're running jspm 0.16 or jspm 0.17 here? |
|
0.17.0-beta.9 |
This is causing an old and broken version of has-cors to get installed when you try and install socket.io.
Without it I am able to install socket.io, pending a proper fix to:
jspm/jspm-cli#1571