Skip to content

Update non-production code to fix specs against Rails edge #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 24, 2023
Merged

Update non-production code to fix specs against Rails edge #149

merged 4 commits into from
May 24, 2023

Conversation

tagliala
Copy link
Contributor

@tagliala tagliala commented May 23, 2023 •
edited
Loading

tagliala added 4 commits May 23, 2023 22:50
@tagliala
Remove explicit require of net-* gems
9fa6690 
This has been fixed in Rails and it is not needed anymore
@tagliala
Update rspec-rails dependency
a8ba799 
Bump the requirement to >= 4.0 (which supports Rails >= 4.2) to allow usage
of 6.x version in modern Rails

Close jsonapi-rb#142
@tagliala
Fix a failure in Rails Edge
c66422a 
In Rails Edge, `errors.messages.blank` changed to `Name can’t be blank`,
with a typographic apostrophe

This commit fetches the error message directly from `I18n` to cover
all use cases
@tagliala
Fix params comparison deprecation warning
80cca28 
```
DEPRECATION WARNING: Comparing equality between
`ActionController::Parameters` and a `Hash` is deprecated and will be
removed in Rails 7.2. Please only do comparisons between instances of
`ActionController::Parameters`. If you need to compare to a hash, first
convert it using `ActionController::Parameters#new`.
```
@tagliala tagliala force-pushed the chore/update-development-dependencies branch from a98e208 to 80cca28 Compare May 23, 2023 21:12
@tagliala tagliala changed the title Chore/update development dependencies Update non-production code to pass against Rails edge May 23, 2023
@tagliala tagliala marked this pull request as ready for review May 23, 2023 21:14
@tagliala tagliala changed the title Update non-production code to pass against Rails edge Update non-production code to fix specs against Rails edge May 23, 2023
remear
remear reviewed May 24, 2023
View reviewed changes
@remear remear merged commit a4238ee into jsonapi-rb:master May 24, 2023
@tagliala tagliala deleted the chore/update-development-dependencies branch May 24, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remear remear remear left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Specs do not pass against Rails edge
2 participants
@tagliala @remear