Fix spec when timezone is not UTC #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation generated a time object in the time zone of the machine, so the comparison was failing if the time zone was not UTC Fix jsonapi-rb#135
tagliala
force-pushed
the
bugfix/fix-tz-spec
branch
from
1c17b46 to
c5e7f9d
Compare
|
Thanks for contributing. Sorry it's taken so long. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋🏼 👋🏼 , this is my first attempt to contribute to this gem
The previous implementation generated a time object in the time zone
of the machine, so the comparison was failing if the time zone was not
UTC
Fix #135