Skip to content

Fixed the mobile layout of Groupby menu #2010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SHASHI9705 wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −3
Open

Fixed the mobile layout of Groupby menu #2010

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff91d83
Fixed the mobile layout of Groupby menu
SHASHI9705 Dec 17, 2025
7ff4d3e
heading improvement
SHASHI9705 Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/Headlines.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ const Headline1Tag = ({ children, attributes }: TagProps) => (
<h1
{...attributes}
className={cn(
'text-h1mobile md:text-h1 dark:text-slate-200 font-bold pt-10 mb-6',
'text-[30px] md:text-h1 dark:text-slate-200 font-bold pt-10 mb-6',
attributes?.className,
)}
>
Expand Down
3 changes: 1 addition & 2 deletions pages/tools/components/GroupByMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,7 @@ const GroupByMenu = ({ transform, setTransform }: GroupByMenuProps) => {
};

return (
<div className='ml-2 my-8 flex items-center space-x-2 max-w-screen overflow-x-auto'>
<span className='text-slate-600 dark:text-slate-300'>GROUP BY:</span>
Copy link
Member

@Utkarsh-123github Utkarsh-123github Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need the text GROUP BY.

Copy link
Contributor Author

@SHASHI9705 SHASHI9705 Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I proposed something else in the issue , #1989 kindly review and tell what changes you want.

Copy link
Member

@Utkarsh-123github Utkarsh-123github Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked and I know what you're trying to say, but we cannot get rid of "GROUP BY" word because it indicates the functionality. So, if there's a way that we can keep that intact then it would be great.

Copy link

@EncrypterParv EncrypterParv Dec 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I have understood the issue and has drafted a pr which preserves "GROUP BY" word while at the same time making its UI cleaner for smaller screens. Would love to contribute so please assign me on this pr.

<div className='ml-2 my-8 flex justify-center items-center space-x-2 max-w-screen overflow-x-auto'>
{groupBy.map((group) => {
return (
<Button
Expand Down
Loading