Skip to content

Fix unevaluatedProperties with adjacent bool additionalProperties test case #793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix unevaluatedProperties with adjacent bool additionalProperties test case #793

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 30 additions & 1 deletion tests/draft2019-09/unevaluatedProperties.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@
]
},
{
"description": "unevaluatedProperties with adjacent additionalProperties",
"description": "unevaluatedProperties with adjacent bool additionalProperties",
"schema": {
"$schema": "https://json-schema.org/draft/2019-09/schema",
"type": "object",
Expand Down Expand Up @@ -160,6 +160,35 @@
}
]
},
{
"description": "unevaluatedProperties with adjacent non-bool additionalProperties",
"schema": {
"$schema": "https://json-schema.org/draft/2019-09/schema",
"type": "object",
"properties": {
"foo": { "type": "string" }
},
"additionalProperties": {"type": "string"},
"unevaluatedProperties": false
},
"tests": [
{
"description": "with no additional properties",
"data": {
"foo": "foo"
},
"valid": true
},
{
"description": "with additional properties",
"data": {
"foo": "foo",
"bar": "bar"
},
"valid": true
}
]
},
{
"description": "unevaluatedProperties with nested properties",
"schema": {
Expand Down
18 changes: 13 additions & 5 deletions tests/draft2020-12/unevaluatedProperties.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,10 @@
"description": "unevaluatedProperties with adjacent bool additionalProperties",
"schema": {
"$schema": "https://json-schema.org/draft/2020-12/schema",
"type": "object",
"properties": {
"foo": { "type": "string" }
},
"additionalProperties": true,
"unevaluatedProperties": false
},
Expand All @@ -155,24 +159,28 @@
"description": "unevaluatedProperties with adjacent non-bool additionalProperties",
"schema": {
"$schema": "https://json-schema.org/draft/2020-12/schema",
"additionalProperties": { "type": "string" },
"type": "object",
"properties": {
"foo": { "type": "string" }
},
"additionalProperties": {"type": "string"},
"unevaluatedProperties": false
},
"tests": [
{
"description": "with only valid additional properties",
"description": "with no additional properties",
"data": {
"foo": "foo"
},
"valid": true
},
{
"description": "with invalid additional properties",
"description": "with additional properties",
"data": {
"foo": "foo",
"bar": 1
"bar": "bar"
},
"valid": false
"valid": true
}
]
},
Expand Down
31 changes: 30 additions & 1 deletion tests/v1/unevaluatedProperties.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@
]
},
{
"description": "unevaluatedProperties with adjacent additionalProperties",
"description": "unevaluatedProperties with adjacent bool additionalProperties",
"schema": {
"$schema": "https://json-schema.org/v1",
"type": "object",
Expand Down Expand Up @@ -160,6 +160,35 @@
}
]
},
{
"description": "unevaluatedProperties with adjacent non-bool additionalProperties",
"schema": {
"$schema": "https://json-schema.org/v1",
"type": "object",
"properties": {
"foo": { "type": "string" }
},
"additionalProperties": {"type": "string"},
"unevaluatedProperties": false
},
"tests": [
{
"description": "with no additional properties",
"data": {
"foo": "foo"
},
"valid": true
},
{
"description": "with additional properties",
"data": {
"foo": "foo",
"bar": "bar"
},
"valid": true
}
]
},
{
"description": "unevaluatedProperties with nested properties",
"schema": {
Expand Down
Loading