Skip to content

Throw when AddOpenApiForJsonApi is called before AddJsonApi #1737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025

Conversation

bkoelman
Copy link
Member

@bkoelman bkoelman commented Jun 3, 2025

Fixes #1734.

QUALITY CHECKLIST

Copy link

codecov bot commented Jun 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.75%. Comparing base (86cee8b) to head (5ed58f2).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1737      +/-   ##
==========================================
- Coverage   90.76%   90.75%   -0.02%     
==========================================
  Files         468      468              
  Lines       14658    14662       +4     
  Branches     2314     2315       +1     
==========================================
+ Hits        13305    13306       +1     
- Misses        917      920       +3     
  Partials      436      436              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bkoelman bkoelman marked this pull request as ready for review June 3, 2025 22:44
@bkoelman bkoelman merged commit 3c6d3be into master Jun 3, 2025
16 checks passed
@bkoelman bkoelman deleted the openapi-throw-invalid-order branch June 3, 2025 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Calling AddOpenApiForJsonApi before AddJsonApi regenerates/re-registers controllers, causing an error
1 participant