Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Store support #104

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Windows Store support #104

wants to merge 9 commits into from

Conversation

phofman
Copy link

@phofman phofman commented Sep 22, 2015

I needed the Windows Store 8.1 support for this library and since it was not there originally I did the port to PCL. This wasn't extremely hard, but please review my changes and check, if they match your coding style.

Please update the NuGet packages accordingly.

Thanks.

@jskeet
Copy link
Owner

jskeet commented Sep 22, 2015

I'll try to have a look when I can, but this project is largely unmaintained now - I'm not doing much work on it, instead concentrating on the proto3 implementation as part of the main protobuf repository (https://github.com/google'protobuf)

Have you signed the Google CLA by the way? I'll need that before I can merge anyway. See https://cla.developers.google.com/about/google-individual

@phofman
Copy link
Author

phofman commented Sep 22, 2015

Thanks a lot. I just signed the CLA, but I have no idea, how to export it. I hope you can retrieve it somehow or could instruct me further.

I wish to use proto3, but since C# support is still in alpha there, I was looking here searching for more stable version. For sure I am not going to introduce any new features ;) My changes are mostly around using updated reflection API and missing IConvertible interface. After few tweaks my sample app for Windows Store 8.1 and Windows Phone 8.1 started to work. Let's keep fingers crossed to have it running also after obfuscation and native compilation on Windows 10...

@jskeet
Copy link
Owner

jskeet commented Sep 23, 2015

Yup, I've just confirmed that you've signed the CLA :)

You can certainly continue using this version, of course - just don't expect it to be maintained nearly as actively. It'll be on a "best effort" basis - so you should expect to use your own build rather than an updated NuGet package, at least for a significant period. I'll try to get to this at some point though :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants