Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: http2 support #16

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: http2 support #16

wants to merge 3 commits into from

Conversation

bjohansebas
Copy link
Member

Support for HTTP/2 is added as part of supporting HTTP/2 in compression and in the future, in express

@bjohansebas bjohansebas force-pushed the http2 branch 4 times, most recently from 9da16ff to 614b831 Compare January 31, 2025 02:00

Verified

This commit was signed with the committer’s verified signature.
nickzelei Nick Zelei
@bjohansebas
Copy link
Member Author

Currently, there is a test that, although it is not failing, is still showing a warning in Node.js. I will need to investigate the best way to proceed

image

@bjohansebas
Copy link
Member Author

@jshttp/express-tc given that writeHead can receive a string as the second parameter, which is not supported in HTTP/2, should we throw an error?

@wesleytodd
Copy link
Member

I can look through this in more detail, but I wanted to first ask if we should just drop node versions so we can remove the try/catch on require('http2)?

@bjohansebas
Copy link
Member Author

I'm fine with removing support for older Node versions in this package, but I don't think that should go in this PR

@bjohansebas
Copy link
Member Author

I guess we shouldn't do anything in this case, right?
#16 (comment)

@wesleytodd
Copy link
Member

I mean that is coming from the tests here right? I didn't really dig into that, but I am not sure throwing an error is desirable if node is treating it as a warning.

@bjohansebas
Copy link
Member Author

Yep, that's why my philosophical doubt. So for now, no error, maybe it's good that Node.js throws the error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants