Skip to content

Commit

Permalink
Fix isFinished(req) when data buffered
Browse files Browse the repository at this point in the history
  • Loading branch information
dougwilson committed Apr 23, 2015
1 parent 4a62fd1 commit bd0a273
Show file tree
Hide file tree
Showing 3 changed files with 24 additions and 1 deletion.
5 changes: 5 additions & 0 deletions HISTORY.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
unreleased
==========

* Fix `isFinished(req)` when data buffered

2.2.0 / 2014-12-22
==================

Expand Down
2 changes: 1 addition & 1 deletion index.js
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ function isFinished(msg) {

if (typeof msg.complete === 'boolean') {
// IncomingMessage
return Boolean(!socket || msg.complete || !socket.readable)
return Boolean(!socket || !socket.readable || (msg.complete && !msg.readable))
}

// don't know
Expand Down
18 changes: 18 additions & 0 deletions test/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -551,6 +551,24 @@ describe('isFinished(req)', function () {
sendget(server)
})

describe('when request data buffered', function () {
it('should be false before request finishes', function (done) {
var server = http.createServer(function (req, res) {
assert.ok(!onFinished.isFinished(req))

req.pause()
setTimeout(function () {
assert.ok(!onFinished.isFinished(req))
req.resume()
res.end()
done()
}, 10)
})

sendget(server)
})
})

describe('when request errors', function () {
it('should return true', function (done) {
var server = http.createServer(function (req, res) {
Expand Down

0 comments on commit bd0a273

Please sign in to comment.