update node 8 version and pin nyc.

closes #48 Similar fix as jshttp/http-errors#109
jshttp · Mar 28, 2024 · 12be913 · 12be913
1 parent c94df7d
commit 12be913
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -22,6 +22,9 @@ jobs:
         - Node.js 7.x
         - Node.js 8.0 # test early async_hooks
         - Node.js 8.x
+        # test fail on Node.js 9.x for unknown reasons
+        # See https://github.com/jshttp/on-finished/pull/49 for more information.
+        # - Node.js 9.x
         - Node.js 10.x
         - Node.js 11.x
         - Node.js 12.x
@@ -80,8 +83,13 @@ jobs:
 
         - name: Node.js 8.x
           node-version: "8.17"
-          npm-i: [email protected]
+          npm-i: [email protected] [email protected]
 
+        # test fail on Node.js 9.x for unknown reasons
+        # See https://github.com/jshttp/on-finished/pull/49 for more information.
+        # - name: Node.js 9.x
+        #   node-version: "9.11"
+        #   npm-i: [email protected] [email protected]
         - name: Node.js 10.x
           node-version: "10.24"
           npm-i: [email protected]