Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds application/geo+json custom type. #61

Closed
wants to merge 3 commits into from
Closed

Adds application/geo+json custom type. #61

wants to merge 3 commits into from

Conversation

TobiTonner
Copy link
Contributor

No description provided.

@dougwilson dougwilson self-assigned this Jan 11, 2017
@dougwilson dougwilson self-requested a review January 11, 2017 16:04
dougwilson
dougwilson approved these changes Jan 15, 2017
View reviewed changes
Copy link
Contributor

@dougwilson dougwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dougwilson
Copy link
Contributor

I spoke a bit too soon. Looks like due to the way mime-types and other libraries are trying to create a reverse map from this module, the inclusion of .json is causing those modules to think .json equals application/geo+json with this patch.

Pending #20 for now I'm going to merge with altered to remove the .json extension and leave only .geojson.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougwilson dougwilson dougwilson approved these changes

Assignees

@dougwilson dougwilson

Labels
enhancement pr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TobiTonner @dougwilson