Merge pull request #222 from jshemas/june-2

adding a new favicon fallback using appIcon
jshemas · Jun 3, 2024 · e0746b0 · e0746b0
2 parents e719dd0 + de0e3b8
commit e0746b0
Show file tree

Hide file tree

Showing 6 changed files with 321 additions and 310 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,10 @@
 # Change Log
 
+## 6.5.2
+
+- adding a new favicon fallback using appIcon
+- Updating dependencies to fix npm vulnerabilities
+
 ## 6.5.1
 
 - jsonLD is now a array of objects since there can be more then one jsonLD tag pre page

diff --git a/dist/lib/fallback.js b/dist/lib/fallback.js
@@ -185,6 +185,9 @@ function fallback(ogObject, options, $, body) {
         else if (doesElementExist('link[type="image/x-icon"]', 'href', $)) {
             ogObject.favicon = $('link[type="image/x-icon"]').attr('href');
         }
+        else if (doesElementExist('head > meta[property*="appIcon"]', 'content', $)) {
+            ogObject.favicon = $('head > meta[property*="appIcon"]').attr('content');
+        }
     }
     // set the charset
     if (doesElementExist('meta', 'charset', $)) {

diff --git a/lib/fallback.ts b/lib/fallback.ts
@@ -167,6 +167,8 @@ export function fallback(ogObject: OgObjectInteral, options: OpenGraphScraperOpt
       ogObject.favicon = $('link[type="image/ico"]').attr('href');
     } else if (doesElementExist('link[type="image/x-icon"]', 'href', $)) {
       ogObject.favicon = $('link[type="image/x-icon"]').attr('href');
+    } else if (doesElementExist('head > meta[property*="appIcon"]', 'content', $)) {
+      ogObject.favicon = $('head > meta[property*="appIcon"]').attr('content');
     }
   }