remove new lines from jsonLD

jshemas · Sep 17, 2024 · 12e3711 · 12e3711
1 parent 98e7f2b
commit 12e3711
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 0 deletions.
diff --git a/lib/extract.ts b/lib/extract.ts
@@ -97,6 +97,7 @@ export default function extractMetaTags(body: string, options: OpenGraphScraperO
         if (!ogObject.jsonLD) ogObject.jsonLD = [];
         let scriptText = $(script).text();
         if (scriptText) {
+          scriptText = scriptText.replace(/(\r\n|\n|\r)/gm, ''); // remove newlines
           scriptText = unescapeScriptText(scriptText);
           ogObject.jsonLD.push(JSON.parse(scriptText));
         }

diff --git a/tests/unit/static.spec.ts b/tests/unit/static.spec.ts
@@ -235,6 +235,28 @@ describe('static check meta tags', function () {
       });
   });
 
+  it('jsonLD - with new lines', function () {
+    const metaHTML = `<html><head>
+    <script type="application/ld+json">{"foo":"
+    bar
+    "}</script>
+    <script type="application/ld+json"></script>
+    </head></html>`;
+
+    mockAgent.get('http://www.test.com')
+      .intercept({ path: '/' })
+      .reply(200, metaHTML);
+
+    return ogs({ url: 'www.test.com' })
+      .then(function (data) {
+        expect(data.result.success).to.be.eql(true);
+        expect(data.result.requestUrl).to.be.eql('http://www.test.com');
+        expect(data.result.jsonLD).to.be.eql([{ foo: '    bar    ' }]);
+        expect(data.html).to.be.eql(metaHTML);
+        expect(data.response).to.be.a('response');
+      });
+  });
+
   it('encoding - utf-8', function () {
     /* eslint-disable max-len */
     const metaHTML = `<html><head>