fix demisjohn#23: object keeps a reference to local variable

jsenellart · Mar 21, 2023 · e340dcb · e340dcb
1 parent 520c1c6
commit e340dcb
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/camfr/waveguide.h b/camfr/waveguide.h
@@ -61,10 +61,12 @@ class Waveguide
 {
   public:
 
-    Waveguide(bool uniform_=false, Material* core_=NULL)
-      : uniform(uniform_), core(core_) {}
-
-    virtual ~Waveguide() {interface_cache.deregister(this);} // Important!
+    Waveguide(bool uniform_=false, Material* core_=NULL): uniform(uniform_), core(new Material(*core_)) {}
+
+    virtual ~Waveguide() {
+        delete core;
+        interface_cache.deregister(this);  // Important!
+    }
 
     bool    is_uniform() const {return uniform;}
     Material* get_core() const {return core;}