Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add sponsor deadline feature #474

Merged
merged 4 commits into from
Oct 31, 2024
Merged

feat: add sponsor deadline feature #474

merged 4 commits into from
Oct 31, 2024

Conversation

ansh-saini
Copy link
Contributor

Fixes #471

@netlify Netlify
Copy link

netlify bot commented Oct 29, 2024 •
edited
Loading

✅ Deploy Preview for jsconf-jp-preview ready!

Name Link
🔨 Latest commit 683afa9
🔍 Latest deploy log https://app.netlify.com/sites/jsconf-jp-preview/deploys/672344a0ce853500083881e8
😎 Deploy Preview https://deploy-preview-474--jsconf-jp-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ansh-saini
Copy link
Contributor Author

@martinheidegger Can you please review this?

@ansh-saini
Copy link
Contributor Author

Hey @martinheidegger I'll continue to work on this PR, but can you please add the hacktoberfest-accepted label on this PR so it can count towards my hacktoberfest contributions?

martinheidegger
martinheidegger requested changes Oct 31, 2024
View reviewed changes
Copy link
Member

@martinheidegger martinheidegger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments.

2024/src/pages/index.tsx Outdated Show resolved Hide resolved
2024/src/pages/index.tsx Outdated Show resolved Hide resolved
@ansh-saini
Copy link
Contributor Author

@martinheidegger Thank you for the review, I've added some replies to your suggestions.

@martinheidegger
Copy link
Member

Also, please rebase

@ansh-saini
Copy link
Contributor Author

@martinheidegger Done!

martinheidegger
martinheidegger approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@martinheidegger martinheidegger left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@martinheidegger martinheidegger merged commit a805431 into jsconfjp:master Oct 31, 2024
2 checks passed
@ansh-saini
Copy link
Contributor Author

ansh-saini commented Oct 31, 2024 •
edited
Loading

@martinheidegger Thank you for the quick review and merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinheidegger martinheidegger martinheidegger approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hide sponsor section on landing page
2 participants
@ansh-saini @martinheidegger