Skip to content

whoasked.js.org #9966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2025
Merged

whoasked.js.org #9966

merged 1 commit into from
Jul 17, 2025

Conversation

mathdebate09
Copy link
Contributor

The site content is landing page for an npm library "who-asked"

@mathdebate09 mathdebate09 changed the title adding subdomain "whoasked" whoasked.js.org Jul 15, 2025
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Commit valid, CNAME present, site appears to have content *

* based off https://github.com/mathdebate09/who-asked/tree/docs/src

@MattIPv4 MattIPv4 added add This PR/issue is regarding adding a new subdomain user This PR/issue is regarding a target on a GitHub user account project This PR has a target of a project on an organisation or user account labels Jul 15, 2025
@indus indus added the error The page requested returns an error label Jul 16, 2025
@indus
Copy link
Member

indus commented Jul 16, 2025

I've already added your requested subdomain to JS.ORGs zonefile. But your page returns errors due to the changed basepath: https://whoasked.js.org
Could you please fix those to give me a chance to look at it before I merge.
Please keep this PR open.

@mathdebate09
Copy link
Contributor Author

Yes it's fixed now, what I did was include a wrong base in vite config
I've made the changes and it works fine now
Thanks for helping me out though!

@indus indus removed the error The page requested returns an error label Jul 17, 2025
@indus
Copy link
Member

indus commented Jul 17, 2025

Welcome https://whoasked.js.org

@indus indus merged commit 954f055 into js-org:master Jul 17, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain project This PR has a target of a project on an organisation or user account user This PR/issue is regarding a target on a GitHub user account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants