Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix _WIN32 definition for Python #273

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix _WIN32 definition for Python #273

wants to merge 2 commits into from

Conversation

mati865
Copy link

@mati865 mati865 commented Oct 8, 2019 •
edited
Loading

Windows code have typo that causes build to fail:

x86_64-w64-mingw32-gcc: error: unrecognized command line option '-_WIN32'

When passing defines from command line they must be prepended with -D but it was prepended only by -.

jruizgit
jruizgit reviewed Oct 9, 2019
View reviewed changes
Copy link
Owner

@jruizgit jruizgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for posting the pull request. Would you mind describing what problem this change addresses?

@mati865
Copy link
Author

mati865 commented Oct 9, 2019

Updated description, hope it's clear now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jruizgit jruizgit jruizgit left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mati865 @jruizgit