Added context.Context support #180
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the method `MainLoopWithContext`, which allows for callers to supply their own context for running a `Gui`. I made this addition because of a project I'm personally working on (and hope to add to the README list soon). My project is heavily concurrent and their exists an abstraction layer between the `Gui` and a backend. The abstraction layer handles many things, mainly monitoring `os.Signal`s and others, which means I couldn't/(don't want to) allow `Gui` to handle termination. Currently, there is no way to solve my problem. Hence, this pull request adds the solution to my problem and hopefully brings even more possibilities to what can be done with `gocui`.
makyo
pushed a commit
to makyo/gotui
that referenced
this pull request
Feb 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the method
MainLoopWithContext, which allows for callers to supply their own context for running aGui. I made this addition because of a project I'm personally working on (and hope to add to the README list soon). My project is heavily concurrent and their exists an abstraction layer between theGuiand a backend. The abstraction layer handles many things, mainly monitoringos.Signals, which means I couldn't/(don't want to) allowGuito handle termination. Currently, there is no way to solve my problem. Hence, this pull request adds the solution to my problem and hopefully brings even more possibilities to what can be done withgocui.