Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pytest_bdd 7.1.2 and later #1878

Merged
merged 3 commits into from
Mar 28, 2024

Conversation

musicinmybrain
Copy link
Contributor

Fix #1875.

This is the most straightforward way to work around #1875 if you want to preserve compatibility with pytest_bdd 7.1.1 and older. If you want to require pytest_bdd 7.1.2, you could drop the try/except.

In either case, the inject_fixture function is considered undocumented and unsupported, so it’s worth considering whether jrnl can avoid using it entirely.

Checklist

  • I have read the contributing doc.
  • I have included a link to the relevant issue number.
  • I have checked to ensure there aren't other open pull requests
    for the same issue.
  • I have written new tests for these changes, as needed. N/A

@musicinmybrain
Copy link
Contributor Author

Lots of tests are failing, but I don’t think they are related to this PR, which works as a downstream patch for release 4.1.

@micahellison
Copy link
Member

Thanks @musicinmybrain for the PR and analysis. Looks like there is another issue, but it's with pytest 8.1. I'm excluding that version for now to get this passing.

@micahellison micahellison added the test Issues related to tests we need to add label Mar 28, 2024
@micahellison micahellison merged commit 48b61f6 into jrnl-org:develop Mar 28, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues related to tests we need to add
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests failing on develop branch starting with pytest-bdd 7.1.2
2 participants