-
-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace flake8 and isort with ruff linter and add black --check
to linting step
#1763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ding a noqa ignore directive to longer lines that look best as they are. Their dedented length is still less than 88
…lack formatting issues
wren
approved these changes
Jul 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐩
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
black --check
to the linting step. Fixes Linting rules aren't enforced the same as format rules #1742.While flakeheaven has worked out well for us, it is an order of magnitude slower than ruff on my machine. Moreover, ruff's configuration feels a lot simpler -- we don't have to install a bunch of packages for various rule sets.
FlakeHeaven was ignoring long lines with comments or strings, whereas ruff is a bit more strict. I reworded comments as necessary and broke long strings into multiple lines. In a couple instances, I added the
noqa
directive to ignore this rule on particular lines since I think they're already most readable in their current forms.This should only affect developers, and developers shouldn't have to change anything in their process. Just keep running
poe lint
for linting checks andpoe format
to automatically sort imports and allow black to reformat code.Checklist
for the same issue.