-
-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python 3.12 support #1761
Add Python 3.12 support #1761
Conversation
It looks like flakeheaven--or our particular setup--isn't ready for Python 3.12 beta. Replacing flakeheaven with ruff is also on my agenda right now so I'll leave this unresolved until that's taken care of. |
We're fine with linting now, but the next step is to deal with the ansiwrap issue in #1693. |
It looks like we have issues with two sub-dependencies:
I'll probably wait at least a couple more weeks before revisiting this. Once the deps are ready, we'll still have to address any potential new test failures. |
I still see the same problem with cryptography's sub-dependency cffi, though it looks like the maintainer is planning on fixing it soon. |
I don't think we'll be ready to support Python 3.12 by the October 2nd release date at this rate. The cryptography/cffi issue remains, though I do see that there is ongoing work on it upstream. I'll keep checking in the coming weeks. |
I resolved the pyyaml issue simply by running |
All the tests are passing in CI now, but jrnl will not work in a normal Windows environment with Python 3.12 right now. I can't install jrnl on my Windows 10 machine because there are no wheels for ruamel.yaml's sub-dependency ruamel.yaml.clib. I filed an issue in ruamel.yaml.clib and the maintainer is already aware of it. This problem leads to this error when I run
I am assuming that the CI build for Windows in Python 3.12 is green right now because the GitHub Actions Windows runner has all sorts of Microsoft build tools pre-installed. It must have built the sub-dependency. But we absolutely don't want to require these build tools for Windows jrnl users, so let's hold off until that wheel is available. |
Still waiting for a wheel from ruamel.yaml.clib, which doesn't have Python 3.12 Windows wheels because the Appveyor service that builds it doesn't support 3.12. I'll check back after the related issue is resolved: appveyor/ci#3879 |
ruamel.yaml.clib just released the Python 3.12 Windows wheels, and it is installing just fine on my machine. This is ready for review now. |
AppVeyor updated their images with Python 3.12 (appveyor/ci#3879). |
Fixes #1750. Adds Python 3.12 to continuous integration and updates sub-dependencies for 3.12 compatibility.
Checklist
for the same issue.