Code

Dialog: Add aria-modal support#2257

Code

Merged

mgol merged 15 commits intojquery:mainjquery/jquery-ui:mainfrom rpkoller:2246-improve-screenreader-supportrpkoller/jquery-ui:2246-improve-screenreader-supportCopy head branch name to clipboardJun 14, 2024

+39-1

Commits

Commits on May 24, 2024

• Add aria-modal attribute true to dialog modal wrapper

  rpkoller

  committed
  a8a6e26

  Copy full SHA for a8a6e26

• Add a test if aria-modal attribute is there and true

  rpkoller

  committed
  729c6d0

  Copy full SHA for 729c6d0

• fix: increasing # of expected asserts from 4 to 5

  rpkoller

  committed
  268dc62

  Copy full SHA for 268dc62

Commits on May 31, 2024

• only add aria-modal when this.options.modal is set to true

  Show description for 7f88e7f
  

  rpkoller

  and

  mgol

  authored
  7f88e7f

  Copy full SHA for 7f88e7f

Commits on Jun 7, 2024

• revert the ARIA test back to its initial form per @mgols recommendation

  rpkoller

  committed
  22ea1a7

  Copy full SHA for 22ea1a7

Commits on Jun 11, 2024

• Initial draft for the aria-modal test

  rpkoller

  committed
  546144d

  Copy full SHA for 546144d

• Fixing initial draft that contained odd unintended changes

  rpkoller

  committed
  2506b1c

  Copy full SHA for 2506b1c

Commits on Jun 12, 2024

• change option to options for the dialog modal options

  rpkoller

  committed
  4810065

  Copy full SHA for 4810065

Commits on Jun 14, 2024

• Add check for modal to _setOption method

  rpkoller

  committed
  8283b78

  Copy full SHA for 8283b78

• applying mgol's suggested changes to the aria-modal test

  rpkoller

  committed
  42edf77

  Copy full SHA for 42edf77

• Apply suggestions from code review

  mgol

  authored
  174bb27

  Copy full SHA for 174bb27

• Avoid setting the modal option to null

  mgol

  authored
  e42ab78

  Copy full SHA for e42ab78

• Update tests/unit/dialog/core.js

  mgol

  authored
  3da0e24

  Copy full SHA for 3da0e24

• Only declare element & wrapper once in tests

  mgol

  authored
  67490a0

  Copy full SHA for 67490a0

• Fix indentation

  mgol

  authored
  2b40401

  Copy full SHA for 2b40401