Core: Fix the selector module, make CI green #552
Conversation
|
Since Edge in IE mode only covers IE 11, I also run the following locally on this branch and it passed: |
|
Reviewing with whitespace changes disabled is much easier, BTW (too much indenting). |
| expectWarning : | ||
| function( _assert, _title, fn ) { | ||
| fn(); | ||
| assert.ok( true, "No Proxy => warnings not expected" ); |
There was a problem hiding this comment.
This is added so that the number of assertions is identical in both versions.
| @@ -58,7 +58,7 @@ | |||
| "qunit": "2.21.0", | |||
| "rollup": "4.22.4", | |||
| "selenium-webdriver": "4.21.0", | |||
| "sinon": "9.2.4", | |||
There was a problem hiding this comment.
I almost said something in the previous PR, but forgot the main branch still supports IE9.
| @@ -1,3 +1,4 @@ | |||
| import { jQueryVersionSince } from "../compareVersions.js"; | |||
There was a problem hiding this comment.
Does this import mean we don't need it as a global in the eslint config?
There was a problem hiding this comment.
Imports are in source, globals are in tests; the ESLint global is for tests. Tests are loaded as regular scripts.
There was a problem hiding this comment.
...which annoys me a lot, as WebStorm keeps inserting the imports the first time I add usage in a test file and I have to remove it. 😅 When we no longer support IE, we can consider loading test files as modules and remove all the globals (plus, this would allow us to only keep one version of these utils; now they're duplicated).
Changes: 1. Support legacy pseudos only in jQuery 3.7.0+. 2. Downgrade sinon to a version working with IE 9+. 3. Skip cross-domain ajax tests in IE 9. 4. Skip tests requiring `jQuery.Deferred.getErrorHook` in <3.7. 5. Don't require warnings for backwards-compatible pseudos if Proxy unsupported.
Note: Please don't review the first commit, that's #551. I based it like that so that I can see the tests pass; it should be "unbased" before merging. For this reason alone I'm marking this as a draft.Changes:
jQuery.Deferred.getErrorHookin <3.7.