Fix calloc error on @base64d format (ref #3280)
#3286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a regression of a8ce2ff, e.g. `"=" | @base64d`.
wader
reviewed
Mar 5, 2025
| return jv_string(""); | ||
| } | ||
| size_t decoded_len = (3 * (size_t)len) / 4; // 3 usable bytes for every 4 bytes of input | ||
| size_t decoded_len = MAX((3 * (size_t)len) / 4, 1); // 3 usable bytes for every 4 bytes of input |
There was a problem hiding this comment.
Ah doh sorry, yeah my suggetion wont work 👍 think i've convinced myself that below code in the case of len < 4 will not be able to write outside result
wader
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a regression of a8ce2ff, e.g.
"=" | @base64d.