Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: jv_number_value should cache the double value of literal numbers #3245

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: jv_number_value should cache the double value of literal numbers #3245

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions src/jv.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,9 +206,6 @@ enum {
JVP_NUMBER_DECIMAL = 1
};

#define JV_NUMBER_SIZE_INIT (0)
#define JV_NUMBER_SIZE_CONVERTED (1)

#define JVP_FLAGS_NUMBER_NATIVE JVP_MAKE_FLAGS(JV_KIND_NUMBER, JVP_MAKE_PFLAGS(JVP_NUMBER_NATIVE, 0))
#define JVP_FLAGS_NUMBER_LITERAL JVP_MAKE_FLAGS(JV_KIND_NUMBER, JVP_MAKE_PFLAGS(JVP_NUMBER_DECIMAL, 1))

Expand Down Expand Up @@ -590,7 +587,7 @@ static jv jvp_literal_number_new(const char * literal) {
return JV_INVALID;
}

jv r = {JVP_FLAGS_NUMBER_LITERAL, 0, 0, JV_NUMBER_SIZE_INIT, {&n->refcnt}};
jv r = {JVP_FLAGS_NUMBER_LITERAL, 0, 0, 0, {&n->refcnt}};
return r;
}

Expand Down Expand Up @@ -698,9 +695,8 @@ double jv_number_value(jv j) {
if (JVP_HAS_FLAGS(j, JVP_FLAGS_NUMBER_LITERAL)) {
jvp_literal_number* n = jvp_literal_number_ptr(j);

if (j.size != JV_NUMBER_SIZE_CONVERTED) {
if (isnan(n->num_double)) {
n->num_double = jvp_literal_number_to_double(j);
j.size = JV_NUMBER_SIZE_CONVERTED;
}

return n->num_double;
Expand Down Expand Up @@ -731,7 +727,7 @@ int jvp_number_is_nan(jv n) {
return decNumberIsNaN(pdec);
}
#endif
return n.u.number != n.u.number;
return isnan(n.u.number);
}

int jvp_number_cmp(jv a, jv b) {
Expand Down
Loading