Split Vagrant provisioning tasks into separate scripts #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces redundancy as the same preparatory tasks (install puppet agent, install puppet modules, prepare module path) do not have to be repeated for on every Vagrant box. This also makes it easier to create custom Vagrantfiles, for example if one wishes to use providers other than Virtualbox.
Puppetlabs yum repository fails quite often. If this happens yum will refuse to install any packages, leaving the provisioned Vagrant VM into an inconsistent state. With this commit Puppetlabs repo failures are treated as non-fatal.
By default the idstat value is randomly generated if not defined. This means that the value will be different between ipa-server-1 and ipa-server-2, because the installer will get different values on each. This caused /home/admin on the ipa-server-2 to have wrong UID and GID, which caused puppet run failures and left the node into inconsistent state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces redundancy as the same preparatory tasks (install puppet agent,
install puppet modules, prepare module path) do not have to be repeated for on
every Vagrant box. This also makes it easier to create custom Vagrantfiles, for
example if one wishes to use providers other than Virtualbox.