Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Django 4.0 #46

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Conversation

Starou
Copy link
Contributor

@Starou Starou commented May 31, 2023

No description provided.

@tenkunkyab
Copy link

@Starou Can I suggest we also update the _make_token_with_timestamp with

        secret = settings.SECRET_KEY + str(user.id) + user.password + str(timestamp)

        # No longer using last login time
        from hashlib import sha1
        hash = sha1(secret.encode('utf-8')).hexdigest()[::2]

        return "%s-%s" % (ts_b36, hash)

I got NameError: name 'unicode' is not defined when hitting .../token/new.json

@Starou
Copy link
Contributor Author

Starou commented Feb 12, 2024

@tenkunkyab: can you be more specific about the error and how to reproduce it please?

@pep8speaks
Copy link

Hello @Starou! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 14:80: E501 line too long (86 > 79 characters)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants