Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credits support #526

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Credits support #526

wants to merge 3 commits into from

Conversation

jacksongoode
Copy link
Collaborator

You can also click on the artists to get to their page!

@jacksongoode jacksongoode mentioned this pull request Sep 25, 2024
@jacksongoode
Copy link
Collaborator Author

@SO9010 Wanted to get this one in but we still need to make sure that clicking credits while there is already a credits window, we don't spawn another.

@SO9010
Copy link
Contributor

SO9010 commented Sep 26, 2024

@jacksongoode I'll have a look at this, but I also think the UI should be consistent with the preferences window if we have a pop-up open. Otherwise, it looks a bit out of place.

Also, I think we should consider changing the order of the right-click context menu. The contexts in the top section are related to going to the track's artist and the album, so maybe we should place it above or below those two contexts.
I also feel that without doing this, people's muscle memory would get in the way of adding the song to their playlist, as that has always been at the bottom.

image
image
Maybe the copy link to track should get moved down to the lower section.
image
However, it could also be ordered as a list of priority to the user, and maybe we could flip it all the way around so that as soon as the user right-clicks on the track, they can add it to a playlist. This could maybe improve UX? Up to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants