linux: Prepare for Flatpak #416
Conversation
TheEvilSkeleton
force-pushed
the
use-app-ids
branch
from
f6882f8
to
f191bab
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| </screenshots> | ||
| <content_rating type="oars-1.1"/> | ||
| <releases> | ||
| <release version="0.1.0" date="2023-05-13"/> |
There was a problem hiding this comment.
We'll have to update the date once it's released
|
@TheEvilSkeleton What else is there to do to finalize the process, just add the mpris privileged? |
|
I think so. Although, per flathub/flathub#4151 (comment), they say it'd be better not to add any additional permission and have it done properly. To be frank, I know nothing about MPRIS. @A6GibKm can you help us out? |
|
If I am not mistaken let mut media_controls = MediaControls::new(PlatformConfig {
dbus_name: APP_ID,
display_name: "Psst",
hwnd,
})?;is the required change. Note that while this would be ideal, it is not strictly needed and one could add a sandbox hole for |
|
@TheEvilSkeleton Do you think this change is reasonable? |
|
In my opinion, yes. I'm in favor of reducing permissions as much as possible. That being said, I'm not well versed in Rust, so I can't give my opinion on the code/implementation. |
|
|
||
| <description> | ||
| <p> | ||
| Fast Spotify client with native GUI, without Electron, built in Rust. Very early in development, lacking in features, stability, and general user experience. It is being tested only on Mac so far, but aims for full Windows and Linux support. Contributions welcome! |
There was a problem hiding this comment.
The "It is being tested only on Mac so far, but aims for full Windows and Linux support." sentence should be removed since Flatpak is only on Linux anyway.
There was a problem hiding this comment.
This file is unlerated to flatpak, it is the app's metainfo.
There was a problem hiding this comment.
That's ok. We've since updated that sentence in the readme so it should be updated here anyways.
|
@TheEvilSkeleton Has the been any movement on this since the Flatpak folks have talked? |
|
Unfortunately, no. I don't have much free time anymore. |
|
I will see if I can find some time to poke at this later. |
|
Yeah it would be good to finally release this thing officially. |
|
Most of the changes for this seem to not be flatpak-specific; maybe merging those separately would be good? |
|
@orowith2os @TheEvilSkeleton Any further interest in seeing if we can get this packaged? |
|
I can only help with packaging-related stuff, but nothing I can help with Rust code |
Related to flathub/flathub#4151 and #141