Upgrade Salt and replace components #618

joshwooding · 2024-06-25T23:12:32Z

No description provided.

vercel · 2024-06-25T23:12:35Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
mosaic	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 28, 2024 9:57am

changeset-bot · 2024-06-25T23:12:36Z

⚠️ No Changeset found

Latest commit: df439be

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

docs/index.mdx

package.json

joshwooding · 2024-06-28T09:29:40Z

packages/components-labs/src/Sitemap/index.tsx

Pretty sure this isn't used

joshwooding · 2024-06-28T09:30:14Z

packages/components/src/FilterToolbar/FilterDropdown/__tests__/index.test.tsx

@@ -13,10 +13,10 @@ test('renders a filter dropdown', async () => {
    </ToolbarProvider>
  );
  // assert
-  expect(getAllByRole('option').length).toEqual(1);
+  expect(getAllByRole('combobox').length).toEqual(1);


DD no longer has a nested option as a label

joshwooding · 2024-06-28T09:30:33Z

packages/components/src/FilterToolbar/FilterDropdown/index.tsx

  /** Callback to translate the selected list item to a Button label */
  labelButton?: (selectedItems: string[] | undefined) => string;
+  /** Dropdown list source */
+  source?: string[];
+  itemToString?: DropdownProps['valueToString'];


Backwards compatible

joshwooding · 2024-06-28T09:32:39Z

packages/components/src/Icon/styles.css.ts

+
+export default {
+  root: style({
+    display: 'contents'


Fixes icons not being centered vertically

joshwooding · 2024-06-28T09:34:57Z

packages/content-editor-plugin/src/components/LinkEditor/SaveAdornment.tsx

 import { ToolbarButton } from '../Toolbar/ToolbarButton';

 interface SaveAdornmentProps {
  onSave: ButtonProps['onClick'];
 }

 export const SaveAdornment = ({ onSave }: SaveAdornmentProps) => (
-  <StaticInputAdornment>


Was missed in a previous update, Input no longer needs this

joshwooding · 2024-06-28T09:35:12Z

packages/content-editor-plugin/src/components/PersistEditDialog/index.tsx

@@ -134,18 +133,16 @@ export const PersistDialog = ({ meta, persistUrl }: PersistDialogProps) => {
        )}
      </DialogContent>
      <DialogActions>
-        <ButtonBar>


ButtonBar doesn't work with normal buttons

joshwooding · 2024-06-28T09:36:17Z

packages/site-components/src/AppHeaderControls/index.tsx

@@ -52,24 +50,16 @@ export const AppHeaderControls: React.FC = () => {
    });
  }
  if (isLoginEnabled && isLoggedIn) {
-    actionMenuOptions = [...actionMenuOptions, { title: 'Logout', link: '/api/auth/signout' }];


Lots of this logic wasn't used and the options don't seem extensible.

joshwooding · 2024-06-28T09:36:37Z

packages/site-components/src/AppHeaderControls/index.tsx

-      >
-        <Icon aria-label="select an action" name="microMenu" />
-      </MenuButton>
+      <Menu placement="bottom-end">


Has a nice side-effect of fixing menu appearing behind the app header

joshwooding · 2024-06-28T09:37:41Z

packages/site-components/src/NavigationItem/NavigationItem.tsx

@@ -7,7 +7,8 @@ import { ExpansionIcon } from './ExpansionIcon';
 import { useWindow } from '@salt-ds/window';
 import { useComponentCssInjection } from '@salt-ds/styles';

-import navigationItemCss from '@salt-ds/core/dist-es/navigation-item/NavigationItem.css.js';
+const navigationItemCss =


Had to inline the CSS, this worked because core was bundled into site-components, but that broke using other components. Adding core to the package.json and inlining this was the easiest way to fix it.

joshwooding · 2024-06-28T09:57:28Z

/release-pr

github-actions · 2024-06-28T10:01:47Z

🫰✨ Thanks @joshwooding! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @jpmorganchase/[email protected]

yarn add @jpmorganchase/[email protected]

yarn add @jpmorganchase/[email protected]

yarn add @jpmorganchase/[email protected]

yarn add @jpmorganchase/[email protected]

yarn add @jpmorganchase/[email protected]

yarn add @jpmorganchase/[email protected]

yarn add @jpmorganchase/[email protected]

yarn add @jpmorganchase/[email protected]

yarn add @jpmorganchase/[email protected]

yarn add @jpmorganchase/[email protected]

yarn add @jpmorganchase/[email protected]

yarn add @jpmorganchase/[email protected]

yarn add @jpmorganchase/[email protected]

yarn add @jpmorganchase/[email protected]

yarn add @jpmorganchase/[email protected]

yarn add @jpmorganchase/[email protected]

yarn add @jpmorganchase/[email protected]

yarn add @jpmorganchase/[email protected]

yarn add @jpmorganchase/[email protected]

yarn add @jpmorganchase/[email protected]

yarn add @jpmorganchase/[email protected]

yarn add @jpmorganchase/[email protected]

yarn add @jpmorganchase/[email protected]

yarn add @jpmorganchase/[email protected]

yarn add @jpmorganchase/[email protected]

yarn add @jpmorganchase/[email protected]

yarn add in 17.69s.

joshwooding requested a review from a team as a code owner June 25, 2024 23:12

vercel bot had a problem deploying to Preview June 25, 2024 23:16 Failure

vercel bot deployed to Preview June 28, 2024 08:58 View deployment

joshwooding commented Jun 28, 2024

View reviewed changes

docs/index.mdx Outdated Show resolved Hide resolved

joshwooding commented Jun 28, 2024

View reviewed changes

package.json Outdated Show resolved Hide resolved

vercel bot deployed to Preview June 28, 2024 09:29 View deployment

joshwooding commented Jun 28, 2024

View reviewed changes

packages/components-labs/src/Sitemap/index.tsx Outdated

Copy link

Contributor Author

joshwooding Jun 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure this isn't used

joshwooding commented Jun 28, 2024

View reviewed changes

joshwooding force-pushed the upgrade-salt branch from c5d0976 to 0b4543d Compare June 28, 2024 09:44

vercel bot deployed to Preview June 28, 2024 09:49 View deployment

joshwooding added 3 commits June 28, 2024 10:50

Upgrade Salt and replace components

ced9237

tests

8fa47d4

Add comments

7ba59ac

joshwooding force-pushed the upgrade-salt branch from 0b4543d to 7ba59ac Compare June 28, 2024 09:51

Update package.json

df439be

vercel bot deployed to Preview June 28, 2024 09:57 View deployment

DavieReid approved these changes Jul 5, 2024

View reviewed changes

DavieReid merged commit 359814e into main Jul 5, 2024
8 checks passed

DavieReid deleted the upgrade-salt branch July 5, 2024 07:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade Salt and replace components #618

Upgrade Salt and replace components #618

joshwooding commented Jun 25, 2024

vercel bot commented Jun 25, 2024 •

edited

Loading

changeset-bot bot commented Jun 25, 2024 •

edited

Loading

joshwooding Jun 28, 2024

joshwooding Jun 28, 2024

joshwooding Jun 28, 2024

joshwooding Jun 28, 2024

joshwooding Jun 28, 2024

joshwooding Jun 28, 2024

joshwooding Jun 28, 2024

joshwooding Jun 28, 2024

joshwooding Jun 28, 2024

joshwooding commented Jun 28, 2024

github-actions bot commented Jun 28, 2024

Upgrade Salt and replace components #618

Upgrade Salt and replace components #618

Conversation

joshwooding commented Jun 25, 2024

vercel bot commented Jun 25, 2024 • edited Loading

changeset-bot bot commented Jun 25, 2024 • edited Loading

⚠️ No Changeset found

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

joshwooding commented Jun 28, 2024

github-actions bot commented Jun 28, 2024

vercel bot commented Jun 25, 2024 •

edited

Loading

changeset-bot bot commented Jun 25, 2024 •

edited

Loading