-
-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement "isPermaLink" for item:guid #89
base: master
Are you sure you want to change the base?
Conversation
Please add this |
ebe9963
to
fd77835
Compare
@neopostmodern, I've solved all conflicts in a new PR (#177) to speed up the merge of this feature. I don't want to steal your job or take advantage of it. Please, let me know if you want me to solve conflicts in your master branch so your PR will be ready to merge. |
@senechaux Thanks for your effort. I've just merged the master into my repo again – if that is good to go I'd be happy to use this PR; if it isn't I don't mind using yours instead either. |
@youssmoh, @jpmonette, is it possible to merge this PR? it's already been approved. |
Please integrate this 👍 |
@youssmoh, @jpmonette, please, let me know if there is something I can help to merge this PR |
Please integrate this |
please merge this PR |
item:guid
has to be a URL unless theisPermaLink
attribute is set to false.I've added this functionality targeting RSS 2.0 and updated tests (for which I need to mangle types a bit -- did these tests pass before I checked them out?)
I believe that the behavior for Atom could/should be updated in some way, because it allows non-URL
item:id
values (Example), but which wouldn't be allowed in RSS 1.0. But this would cause major infrastructure-changes I guess, wheres just adding theisPermaLink
attribute should be non-breaking.