Update controller.py #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Tank name to the plot caption Added get_temp2, to be able to use second sensor on FermenterController
jpgimenez
reviewed
Aug 18, 2020
| @@ -166,3 +166,9 @@ def get_temp(self, id=None): | |||
| id = self.fermenter_id | |||
| return self.get_sensor_value(int(self.api.cache.get("fermenter").get(id).sensor)) | |||
|
|
|||
| @cbpi.try_catch(None) | |||
| def get_temp2(self, id=None): | |||
There was a problem hiding this comment.
probably is better to pass the sensor as a parameter to get_temp method with a default to not break existing code...
There was a problem hiding this comment.
Sorry for may lack of knowledge of pyhon, but how do you pass a member of fermenter as parameter?
get_temp(self, id=None, sens=sensor):
......get(id).sens )) do not work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Tank name to the plot caption
Added get_temp2, to be able to use second sensor on FermenterController
May be sensor3 have to be added too.