Skip to content
This repository was archived by the owner on May 26, 2020. It is now read-only.

Fixed Django version comparisons in test_serializers.#398

Open
felixxm wants to merge 1 commit intojpadilla:masterfrom
felixxm:django-version-comp
Open

Fixed Django version comparisons in test_serializers.#398
felixxm wants to merge 1 commit intojpadilla:masterfrom
felixxm:django-version-comp

Conversation

@felixxm
Copy link
Copy Markdown
Contributor

@felixxm felixxm commented Nov 19, 2017

Required for Django >= 2.0 support.

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 19, 2017

Codecov Report

Merging #398 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #398   +/-   ##
=======================================
  Coverage   90.67%   90.67%           
=======================================
  Files          14       14           
  Lines         847      847           
  Branches       29       29           
=======================================
  Hits          768      768           
  Misses         66       66           
  Partials       13       13
Flag Coverage Δ
#codecov 90.67% <ø> (ø) ⬆️
#dj110 87.48% <ø> (ø) ⬆️
#dj111 87.48% <ø> (ø) ⬆️
#dj18 89.84% <ø> (ø) ⬆️
#dj19 89.84% <ø> (ø) ⬆️
#drf31 89.84% <ø> (ø) ⬆️
#drf32 89.84% <ø> (ø) ⬆️
#drf33 89.84% <ø> (ø) ⬆️
#drf34 90.67% <ø> (ø) ⬆️
#drf35 90.31% <ø> (ø) ⬆️
#drf36 90.31% <ø> (ø) ⬆️
#py27 90.67% <ø> (ø) ⬆️
#py33 89.49% <ø> (ø) ⬆️
#py34 90.31% <ø> (+0.82%) ⬆️
#py35 87.48% <ø> (?)
#py36 87.48% <ø> (?)
Impacted Files Coverage Δ
tests/test_serializers.py 95.31% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a0bd40...ccc91d1. Read the comment docs.

1 similar comment
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 19, 2017 •
edited
Loading

Codecov Report

Merging #398 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #398   +/-   ##
=======================================
  Coverage   90.67%   90.67%           
=======================================
  Files          14       14           
  Lines         847      847           
  Branches       29       29           
=======================================
  Hits          768      768           
  Misses         66       66           
  Partials       13       13
Flag Coverage Δ
#codecov 90.67% <ø> (ø) ⬆️
#dj110 87.48% <ø> (ø) ⬆️
#dj111 87.48% <ø> (ø) ⬆️
#dj18 89.84% <ø> (ø) ⬆️
#dj19 89.84% <ø> (ø) ⬆️
#drf31 89.84% <ø> (ø) ⬆️
#drf32 89.84% <ø> (ø) ⬆️
#drf33 89.84% <ø> (ø) ⬆️
#drf34 90.67% <ø> (ø) ⬆️
#drf35 90.31% <ø> (ø) ⬆️
#drf36 90.31% <ø> (ø) ⬆️
#py27 90.67% <ø> (ø) ⬆️
#py33 89.49% <ø> (ø) ⬆️
#py34 90.31% <ø> (+0.82%) ⬆️
#py35 87.48% <ø> (?)
#py36 87.48% <ø> (?)
Impacted Files Coverage Δ
tests/test_serializers.py 95.31% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a0bd40...ccc91d1. Read the comment docs.

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 19, 2017

Codecov Report

Merging #398 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #398   +/-   ##
=======================================
  Coverage   90.67%   90.67%           
=======================================
  Files          14       14           
  Lines         847      847           
  Branches       29       29           
=======================================
  Hits          768      768           
  Misses         66       66           
  Partials       13       13
Flag Coverage Δ
#codecov 90.67% <ø> (ø) ⬆️
#dj110 87.48% <ø> (ø) ⬆️
#dj111 87.48% <ø> (ø) ⬆️
#dj18 89.84% <ø> (ø) ⬆️
#dj19 89.84% <ø> (ø) ⬆️
#drf31 89.84% <ø> (ø) ⬆️
#drf32 89.84% <ø> (ø) ⬆️
#drf33 89.84% <ø> (ø) ⬆️
#drf34 90.67% <ø> (ø) ⬆️
#drf35 90.31% <ø> (ø) ⬆️
#drf36 90.31% <ø> (ø) ⬆️
#py27 90.67% <ø> (ø) ⬆️
#py33 89.49% <ø> (ø) ⬆️
#py34 90.31% <ø> (+0.82%) ⬆️
#py35 87.48% <ø> (?)
#py36 87.48% <ø> (?)
Impacted Files Coverage Δ
tests/test_serializers.py 95.31% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a0bd40...ccc91d1. Read the comment docs.

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 19, 2017 •
edited
Loading

Codecov Report

Merging #398 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #398   +/-   ##
=======================================
  Coverage   90.67%   90.67%           
=======================================
  Files          14       14           
  Lines         847      847           
  Branches       29       29           
=======================================
  Hits          768      768           
  Misses         66       66           
  Partials       13       13
Flag Coverage Δ
#codecov 90.67% <ø> (ø) ⬆️
#dj110 87.48% <ø> (ø) ⬆️
#dj111 87.48% <ø> (ø) ⬆️
#dj18 89.84% <ø> (ø) ⬆️
#dj19 89.84% <ø> (ø) ⬆️
#drf31 89.84% <ø> (ø) ⬆️
#drf32 89.84% <ø> (ø) ⬆️
#drf33 89.84% <ø> (ø) ⬆️
#drf34 90.67% <ø> (ø) ⬆️
#drf35 90.31% <ø> (ø) ⬆️
#drf36 90.31% <ø> (ø) ⬆️
#py27 90.67% <ø> (ø) ⬆️
#py33 89.49% <ø> (ø) ⬆️
#py34 90.31% <ø> (+0.82%) ⬆️
#py35 87.48% <ø> (?)
#py36 87.48% <ø> (?)
Impacted Files Coverage Δ
tests/test_serializers.py 95.31% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a0bd40...ccc91d1. Read the comment docs.

@jayvdb jayvdb mentioned this pull request Apr 19, 2019
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@felixxm