Small bug fixes

CONFIG: Disable `DIAPHORA_WORKAROUND_MAX_TINFO_T` by default. BUG: For some reason I cannot reproduce, `extract_function_assembly_features()` might fail finding a specific address, workaround it.
joxeankoret · Aug 27, 2024 · 38414a3 · 38414a3
1 parent 232a272
commit 38414a3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/diaphora_config.py b/diaphora_config.py
@@ -224,4 +224,4 @@
 
 #-------------------------------------------------------------------------------
 # Workarounds for IDA bugs
-DIAPHORA_WORKAROUND_MAX_TINFO_T = True
+DIAPHORA_WORKAROUND_MAX_TINFO_T = False
diff --git a/diaphora_ida.py b/diaphora_ida.py
@@ -2650,6 +2650,9 @@ def extract_function_assembly_features(self, assembly, f, image_base):
       keys.remove(base)
     keys.insert(0, base)
     for key in keys:
+      if key not in assembly:
+        log(f"Key not in `assembly` list? Key {key} Assembly {assembly}")
+        continue
       for line in assembly[key]:
         assembly_addrs.append(line[0])
         asm.append(line[1])