Fix build with X2APIC false #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ideally, we want to automatically set X2APIC as per kernel parameters. Currently, sgx-step has X2APIC set to true by default. Because nox2apic used to be required, this introduced a regression causing an unrecoverable system freeze. |
|
Thanks Wojciech for catching this! I clearly need better (automated) testing infrastructure -- currently only ran on an X2APIC machine.. I agree this would ideally be set/deduced automatically.. could even be done at runtime by parsing also |
|
This is now also implemented in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent changes broke sgx-step with the kernel parameter nox2apic. This is a fix.