Merge pull request #84 from w-woloszyn/memset_fix

Fix the incorrect call to memset in app/memcmp, causing UB
jovanbulck · Aug 27, 2024 · fa2a4b5 · fa2a4b5
2 parents 08895a1 + 619a124
commit fa2a4b5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/app/aep-redirect/main.c b/app/aep-redirect/main.c
@@ -101,7 +101,7 @@ void attacker_config_page_table(void) {
     print_pte_adrs(code_pt);
 
     /* Specify #PF handler with signinfo arguments */
-    memset(&act, sizeof(sigaction), 0);
+    memset(&act, 0, sizeof(sigaction));
     act.sa_sigaction = fault_handler;
     act.sa_flags = SA_RESTART | SA_SIGINFO;
 

diff --git a/app/memcmp/main.c b/app/memcmp/main.c
@@ -154,7 +154,7 @@ void register_signal_handler(int signo)
     struct sigaction act, old_act;
 
     /* Specify #PF handler with signinfo arguments */
-    memset(&act, sizeof(sigaction), 0);
+    memset(&act, 0, sizeof(sigaction));
     act.sa_sigaction = fault_handler;
     act.sa_flags = SA_RESTART | SA_SIGINFO;