-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
moved col length checks to cover multi.panel = T as well as being num… #424
moved col length checks to cover multi.panel = T as well as being num… #424
Conversation
tbh, im not sure if we even need to check for mlti.panel. is there any harm in just doing this recycling for all scenarios? |
apply input recycling in all scenarios
Thanks for the PR! I just added a commit that removed some later checks on the length of 'col', 'lty', and 'lwd' so they're only in one place in |
hmm, im getting an error in |
Can you give me an example so I can take a look too? |
x <- as.xts(sample_matrix)
plot(x, multi.panel = TRUE)
addEventLines(xts("a", index(x)[10]), pos = 2:3)
seems to only be drawing on |
That's a bug, but not related to these changes. It's in the prior version on CRAN (0.14.0). EDIT: Actually, it's a bug in the example in the documentation. There's no 'pos' argument to library(xts)
data(sample_matrix)
sample.xts <- as.xts(sample_matrix)
events <- xts(letters[1:3],
as.Date(c("2007-01-12", "2007-04-22", "2007-06-13")))
plot(sample.xts[,4])
addEventLines(events, srt = 90, pos = 2) |
sry, should be |
working fine. all issues were on my end |
moved input length checks up in flow to cover both (multi.panel == TRUE) and (is.numeric(multi.panel))
fixes #423