Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check length of args before popping first element #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ly0
Copy link

@ly0 ly0 commented May 21, 2015

When I wanted to add a decorator of Basic HTTP Authentication to a method of a class, getcallargs thrown an exception.

  File "/Users/admin/codes/rpc/tornadorpc/utils.py", line 26, in getcallargs
    args.pop(0)
IndexError: pop from empty list

Here's the test code:

import functools

def authtest(func):
    @functools.wraps(func)
    def wrapper(*args, **kwargs):
        func._need_authenticated = True
        return func(*args, **kwargs)
    return wrapper

class TestA(object):

    @authtest
    def category(self, slug):
        return 'Done'

class Handler(JSONRPCHandler):

    testa = TestA()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant