Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty bookmarkView #943

Merged
merged 4 commits into from
Oct 22, 2023
Merged

Empty bookmarkView #943

merged 4 commits into from
Oct 22, 2023

Conversation

percy-g2
Copy link
Contributor

Screenshot_1697821761

@joreilly
Copy link
Owner

I think we need to check upcomingSessions as well?

@percy-g2
Copy link
Contributor Author

yes added upcomingSessions check as well.

@percy-g2
Copy link
Contributor Author

@joreilly now showing empty view separately for past and upcoming page now, as it makes more sense to show with tabs present.

@joreilly joreilly merged commit 94f0b5b into joreilly:main Oct 22, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@percy-g2 @joreilly