Add "Close" button to close kanban and disable auto closing #44

benlau · 2023-06-22T02:06:31Z

Implements #21

Added a "close" button at the left of the kanban title to close kanban
Disabled auto closing if user open a note which is not in the current kanban (as user could close the kanban by using the close button)

mhelleboid · 2023-06-22T21:59:34Z

src/index.ts

@@ -127,10 +127,9 @@ async function reloadConfig(noteId: string) {
  const valid = ymlConfig !== null && (await board.loadConfig(ymlConfig));
  if (valid) {
    openBoard = board;
-  } else {
-    openBoard = undefined;


wouldn't it be good to set openBoard as undefined in this case?

Remove the code to prevent the board from closing automatically and keep the current board working.

If it set to undefined, I am afraid the current board will not be working any more.

Ok, I'll need more time to understand the code on my side then

Ok, after additional test, this part is ok

mhelleboid · 2023-06-22T22:06:06Z

This works as described.

The board lifecycle seems to have change a bit, but it seems ok.

Not sure that the initial feature request suggested to also disable the "auto closing". In this case this could be an option.
Anyway, this can be done in an additional commit/branch.

benlau · 2023-06-23T02:20:34Z

@mhelleboid Thanks for reviewing!

yes, the auto closing is not described in the feature requirement.

However, as we now have a close button and therefore I think auto closing is not needed anymore as user could choose when should it be closed. It is more flexible.

Example:

Edit a kanban board
User find that a note should be added to the kanban
Open the note and change folder/tag to add to kanban
The board closed and user need to open the kanban again to resume the works but it may need to wait for a few seconds for reloading

Disable the auto closing feature could save the time for reloading in step 4

@PackElend , what do you think?

mhelleboid · 2023-06-23T06:44:39Z

Ok the scenario makes sense, and I agree that this is a good thing

PackElend · 2023-06-24T20:58:51Z

Sounds good but let me check the history why auto close exsist

benlau · 2023-06-25T03:50:52Z

@PackElend thx. If it is approved, I may try to work on a feature to drag a note from note list to a Kanban column directly.

PackElend · 2023-06-27T09:23:49Z

could find anything and still don't see a reason to keep auto close but others may think differently.
I started a "survey", see https://discourse.joplinapp.org/t/shall-we-replace-auto-close-by-close-button/31440

PackElend · 2023-06-28T13:34:07Z

let's wait for a week, if it is not significant response I'll merge it

PackElend · 2023-06-28T13:36:22Z

I may try to work on a feature to drag a note from note list to a Kanban column directly.

@benlau please go ahead but open a topic in the forum as well, to allow the community to join the development :)

mhelleboid · 2023-07-01T15:11:42Z

src/index.ts

@@ -273,12 +276,19 @@ async function handleKanbanMessage(msg: Action) {
 * the domain of the current board.
 */
 async function handleNewlyOpenedNote(newNoteId: string) {
+
  if (openBoard) {
    if (openBoard.configNoteId === newNoteId) return;
    if (await openBoard.isNoteIdOnBoard(newNoteId)) return;
    else {


this code was already there, but is this "else" useful?

Yes. Let's say you have opened Kanban A note , and then open another Kanban B note, the else code handle this condition and replace the the board to Kanban B. If no such code, you need to close the current board and then open the Kanban note B manually.

Remark: The reloadConfig() replace the "openBoard" variable. That is why it looks a bit weird.

mhelleboid · 2023-07-01T15:13:23Z

The code and the PR is ok for me, from a technical and functional (auto close) point of view

PackElend · 2023-07-05T07:41:42Z

@benlau do you want to add some comments / do changes due to the latest review, if necessary?

So that I can merge it.

benlau · 2023-07-09T02:01:01Z

@PackElend I think it should be ready to merge. thx

AndiLeni · 2024-02-26T22:44:30Z

@benlau Sorry to comment on this old pr, but how do I activate this feature? The button is missing on my end.

benlau · 2024-02-27T03:50:22Z

@AndiLeni I think the change is not published yet.

@PackElend Do you have the permission to release a new version?

PackElend · 2024-02-27T10:43:14Z

Do you have the permission to release a new version?

will check

PackElend · 2024-05-15T19:27:39Z

@mhelleboid
@benlau

Eventually GSoC is rolling smoothly and we are looking into other things.
We get errors when we build it:

> [email protected] prepare
> npm run dist


> [email protected] dist
> webpack --joplin-plugin-config buildMain && webpack --joplin-plugin-config buildExtraScripts && webpack --joplin-plugin-config createArchive

do you get the same when you do that?

it is discussed in https://discord.com/channels/610762468960239627/919979500765335613/1240377195730440274

PackElend · 2024-05-16T06:52:52Z

#50 could fix it, let's see.

Add close button and disable auto-close

031dbf1

mhelleboid reviewed Jun 22, 2023

View reviewed changes

mhelleboid reviewed Jul 1, 2023

View reviewed changes

PackElend merged commit 0e4098d into joplin:dev Jul 10, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add "Close" button to close kanban and disable auto closing #44

Add "Close" button to close kanban and disable auto closing #44

benlau commented Jun 22, 2023

mhelleboid Jun 22, 2023

benlau Jun 23, 2023

benlau Jun 23, 2023

mhelleboid Jun 23, 2023

mhelleboid Jul 1, 2023

mhelleboid commented Jun 22, 2023

benlau commented Jun 23, 2023

mhelleboid commented Jun 23, 2023

PackElend commented Jun 24, 2023

benlau commented Jun 25, 2023

PackElend commented Jun 27, 2023 •

edited

Loading

PackElend commented Jun 28, 2023

PackElend commented Jun 28, 2023

mhelleboid Jul 1, 2023 •

edited

Loading

benlau Jul 9, 2023

benlau Jul 9, 2023

mhelleboid commented Jul 1, 2023

PackElend commented Jul 5, 2023

benlau commented Jul 9, 2023

AndiLeni commented Feb 26, 2024

benlau commented Feb 27, 2024

PackElend commented Feb 27, 2024

PackElend commented May 15, 2024 •

edited

Loading

PackElend commented May 16, 2024

Add "Close" button to close kanban and disable auto closing #44

Add "Close" button to close kanban and disable auto closing #44

Conversation

benlau commented Jun 22, 2023

mhelleboid Jun 22, 2023

Choose a reason for hiding this comment

benlau Jun 23, 2023

Choose a reason for hiding this comment

benlau Jun 23, 2023

Choose a reason for hiding this comment

mhelleboid Jun 23, 2023

Choose a reason for hiding this comment

mhelleboid Jul 1, 2023

Choose a reason for hiding this comment

mhelleboid commented Jun 22, 2023

benlau commented Jun 23, 2023

mhelleboid commented Jun 23, 2023

PackElend commented Jun 24, 2023

benlau commented Jun 25, 2023

PackElend commented Jun 27, 2023 • edited Loading

PackElend commented Jun 28, 2023

PackElend commented Jun 28, 2023

mhelleboid Jul 1, 2023 • edited Loading

Choose a reason for hiding this comment

benlau Jul 9, 2023

Choose a reason for hiding this comment

benlau Jul 9, 2023

Choose a reason for hiding this comment

mhelleboid commented Jul 1, 2023

PackElend commented Jul 5, 2023

benlau commented Jul 9, 2023

AndiLeni commented Feb 26, 2024

benlau commented Feb 27, 2024

PackElend commented Feb 27, 2024

PackElend commented May 15, 2024 • edited Loading

PackElend commented May 16, 2024

PackElend commented Jun 27, 2023 •

edited

Loading

mhelleboid Jul 1, 2023 •

edited

Loading

PackElend commented May 15, 2024 •

edited

Loading