-
Notifications
You must be signed in to change notification settings - Fork 13
Upstream changes v1.0
Following is a list of changes made to the platform that can potentially be merged back upstream. All changes are 100% backwards and forwards compatible.
define('JPATH_WEB’, JPATH_ROOT);
com_media/media.php::43
define('COM_MEDIA_BASE', JPATH_WEB . '/' . $params->get($path, 'images'));
JInstaller::1448
$destination = JPath::clean(JPATH_WEB . '/media' . $folder);
JHtml::*
replace JPATH_ROOT with JPATH_WEB
PlgEditorTinymce::*
replace JPATH_ROOT with JPATH_WEB
JHtmlTest::*
replace JPATH_ROOT with JPATH_WEB
JRouterSite::64
$relativeScriptPath = str_replace('\\', '/', str_replace(JPATH_WEB, '', $scriptPath));
JRouterSite::68
if (file_exists(JPATH_WEB . $matches[0]) && ($matches[0] == $relativeScriptPath))
PlgEditorTinymce::106
$templates_path = JPATH_WEB . '/templates’;
MenusModelMenutypes::357
$folders = JFolder::folders(JPATH_WEB . '/templates', '', false, true);
Commit: https://github.com/joomlatools/joomla-platform/commit/cc84a80c4b0356779ab4294534c992ad768c885d
define('JPATH_LAYOUTS', JPATH_ROOT . '/lib/layouts');
JLayoutFile::367
$this->addIncludePaths(JPATH_LAYOUTS);
Commit: https://github.com/joomlatools/joomla-platform/commit/69be25bc31a418202a66b532780813d389cc755a
JPluginHelper::56
$bPath = JPATH_PLUGINS .'/' . $type . '/' . $name . '/tmpl/' . $defaultLayout . '.php';
JPluginHelper::57 $dPath = JPATH_PLUGINS .'/' . $type . '/' . $name . '/tmpl/default.php';
com_config/config.php::20
JLoader::registerPrefix('Config', JPATH_SITE . '/components/com_config');
JHelperMedia::61 -> check if enabled
public function canUpload($file, $component = 'com_media')
{
if(JComponentHelper::isEnabled($component))
JToolbarHelper::165
if(JComponentHelper::isEnabled('com_media'))
{
$bar = JToolbar::getInstance('toolbar');
// Add an upload button.
$bar->appendButton('Popup', 'upload', $alt, 'index.php?option=com_media&tmpl=component&task=popupUpload&folder=' . $directory, 800, 520);
}
Issue : https://github.com/joomlatools/joomla-platform/issues/179
- Session Fixation #253
- JTableAsset::rebuild() fails #203
- Reference wrong language keys code
- Fix JArrayHelper not found #142
- Do not store the 'mediaVersion' in the database #196
- Use MyISAM engine for users_sessions table #222
Set display_errors to 0 when error_reporting is ‘none’. Use display_errors in JErrorPage, when
generating the error message.
PR : https://github.com/joomlatools/joomla-platform/issues/163
JCrypt::311
include_once JPATH_LIBRARIES . '/compat/password/lib/password.php';
JStringPuncode::12
JLoader::register('idna_convert', JPATH_LIBRARIES . '/idna_convert/idna_convert.class.php');
build.php::43
require_once JPATH_LIBRARIES .'/cms/version/version.php';
mod_articles_categories.php::15
JLoader::register('JCategoryNode', JPATH_LIBRARIES . '/legacy/categories/categories.php');
JFTP::224
$checkValue = file_get_contents(JPATH_LIBRARIES . '/cms/version/version.php');
MenusModelItem::981
$xmlFile = JPath::find(JPATH_ADMINISTRATOR . '/components/com_menus/models/forms', 'item_' . $type . '.xml');
JApplicationCli::299
if (empty($file) && defined('JPATH_CONFIGURATION'))
{
$file = JPATH_CONFIGURATION . '/configuration.php';
JApplicationWeb::907
if (empty($file) && defined('JPATH_CONFIGURATION'))
{
$file = JPATH_CONFIGURATION . '/configuration.php';
JFactory::150
$file = JPATH_CONFIGURATION . '/configuration.php';
Change location of the editor to use default media path.
PlgEditorTinymce::25
protected $_basePath = 'media/plg_editors_tinymce';
and others …
Cleanup media folder to adhere to standard naming schema. Move /media/media to media/com_media
FinderViewSearch::46
Use JProfiler::getInstance('Application') instead of $GLOBALS['_PROFILER']
-
Remove default table prefix from the database layer to allow to run the database without a database prefix Commit: https://github.com/joomlatools/joomla-platform/commit/31037be8857b21f0b1f3204cb28ae75bcfd68510
-
Fix quote schemas database table as it’s a protected name in MySQL. Commit: https://github.com/joomlatools/joomla-platform/commit/2df847c8faeb62268618141ebe9655b61e0fc175
TODO: Rename schemas to extensions_schemas to keep database organised.
PlgSearchTags::144
require_once JPATH_SITE . '/components/com_tags/helpers/route.php';
Issue : https://github.com/joomlatools/joomla-platform/issues/181
Remove tag id to titles logic JDocumentRendererHead. Unneeded coupling and tags are never set as
metadata.
Issue : https://github.com/joomlatools/joomla-platform/issues/191
- https://github.com/joomla/joomla-cms/blob/staging/administrator/language/en-GB/en-GB.plg_installer_webinstaller.sys.ini
- https://github.com/joomla/joomla-cms/blob/staging/administrator/language/en-GB/en-GB.plg_installer_webinstaller.ini
- https://github.com/joomla/joomla-cms/blob/staging/administrator/language/en-GB/en-GB.plg_user_profile.ini#L6
- https://github.com/joomla/joomla-cms/blob/staging/administrator/language/en-GB/en-GB.plg_user_profile.ini#L7
- https://github.com/joomla/joomla-cms/blob/staging/administrator/language/en-GB/en-GB.plg_user_profile.ini#L8
- https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_modules/models/module.php#L873
- https://github.com/joomla/joomla-cms/blob/staging/components/com_search/views/search/view.html.php#L143
- COM_CONTENT_LIST_FULL_ORDERING
- COM_CONTENT_LIST_FULL_ORDERING_DESC
These keys are not defined anywhere in the en-GB language file and not used in the UI.
- https://github.com/joomla/joomla-cms/blob/924e4fad9194c1dfc8c3c1a3ffddeb5fc0abbe5f/administrator/components/com_users/models/forms/filter_users.xml#L53
- https://github.com/joomla/joomla-cms/blob/924e4fad9194c1dfc8c3c1a3ffddeb5fc0abbe5f/administrator/components/com_content/models/forms/filter_articles.xml#L87
- https://github.com/joomla/joomla-cms/blob/924e4fad9194c1dfc8c3c1a3ffddeb5fc0abbe5f/administrator/components/com_content/models/forms/filter_featured.xml#L87
- https://github.com/joomla/joomla-cms/blob/924e4fad9194c1dfc8c3c1a3ffddeb5fc0abbe5f/administrator/components/com_content/models/forms/filter_articles.xml#L87
--
- COM_CONTENT_LIST_LIMIT
- COM_CONTENT_LIST_LIMIT_DESC
These keys are not defined anywhere in the en-GB language file and not used in the UI.
- https://github.com/joomla/joomla-cms/blob/924e4fad9194c1dfc8c3c1a3ffddeb5fc0abbe5f/administrator/components/com_users/models/forms/filter_users.xml#L81
- https://github.com/joomla/joomla-cms/blob/c41fcf023012741e230acac6acbe956f5c275c41/components/com_content/models/forms/filter_articles.xml#L121
- https://github.com/joomla/joomla-cms/blob/924e4fad9194c1dfc8c3c1a3ffddeb5fc0abbe5f/administrator/components/com_content/models/forms/filter_articles.xml#L123
- https://github.com/joomla/joomla-cms/blob/924e4fad9194c1dfc8c3c1a3ffddeb5fc0abbe5f/administrator/components/com_content/models/forms/filter_featured.xml#L119
To uncouple the debug plugin from the css, the loading of the debug.css should happen in the plugin and the plugin should be injected to the bottom of the page by the plugin instead of being loaded using a module position in the template.
Issue : https://github.com/joomlatools/joomla-platform/issues/261